Invalid Commit Message

Open
#117 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
ci-cd, testing-qa

Research direction

Start with the commit-message guidelines and the validation exercised by PR 49730, then trace the check that reported the message-length error. Verify how the commit subject’s opening verb is evaluated. Done means a non-imperative subject such as “added new benchmarks for blob” is rejected by CI while valid imperative wording passes.

Written by the indexing model from the issue text.

Description

This PR was merged with a non-imperative verb starting the commit message: benchmark: added new benchmarks for blob.

From what the docs says, it should be a invalid message.

The CI did raised an error about the length (that I fix) but didn't raise an error about this verb and it was merged.

Dominant language
JavaScript
Stars
55
Forks
62
Avg merge
4d 9h
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nodejs/core-validate-commit

All issues in nodejs/core-validate-commit

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.