Review all tests

Open
#1,136 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Active
Tech stack
javascript
Domain
testing-qa

Research direction

Start by reviewing PR #959 and the related removal PRs referenced in the issue, then compare the current test-review process with the prior version. Done means completing another review cycle and documenting whether the tests and removals are no worse, along with any concerns for the Node.js releasers.

Written by the indexing model from the issue text.

Description

... we should perhaps consider doing another cycle of https://github.com/nodejs/citgm/pull/959 since the current process for @nodejs/releasers (who i'm tagging for awareness/input since there are a few of these removal PRs from Mike) is typically "compare with the last version and make sure it's no worse" which I'd suggest is not ideal although generally works.

Originally posted by @sxa in https://github.com/nodejs/citgm/pull/1123#pullrequestreview-5032654627

Dominant language
JavaScript
Stars
605
Forks
157
Avg merge
3d 23h
Merged PRs (30d)
3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nodejs/citgm

All issues in nodejs/citgm

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.