Handle Content-Type parameter

Open
#1,648 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
backend

Research direction

Start with lib/handlers/put.js lines 15-17 to inspect the error triggered by a parameterized Content-Type, then review lib/utils.js lines 251-254 for where media-type parameters are discarded. The work is done when Content-Type values containing parameters such as charset are accepted and their parameters are preserved.

Written by the indexing model from the issue text.

Description

https://datatracker.ietf.org/doc/html/rfc7231#section-3.1.1.1

When a Content-Type includes a parameter, for example charset, this errors:

https://github.com/solid/node-solid-server/blob/b84789ab03803fff9d7391ad802a9014387716fa/lib/handlers/put.js#L15-L17

Loss of media-type parameters:

https://github.com/solid/node-solid-server/blob/b84789ab03803fff9d7391ad802a9014387716fa/lib/utils.js#L251-L254

Dominant language
JavaScript
Stars
1.8k
Forks
308
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nodeSolidServer/node-solid-server

All issues in nodeSolidServer/node-solid-server

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.