noble/bleno

Crash on bonding

Open

#345 opened on Oct 20, 2017

View on GitHub
 (1 comment) (3 reactions) (0 assignees)JavaScript (2,083 stars) (465 forks)batch import
help wanted

Description

Executed option "Bond" on Bleno device in nRF Connect. Following stacktrace appears

PROJECT/node_modules/bleno/lib/hci-socket/crypto.js:60
  var output = new Buffer(input.length);
                               ^

TypeError: Cannot read property 'length' of undefined
    at swap (PROJECT/node_modules/bleno/lib/hci-socket/crypto.js:60:32)
    at e (PROJECT/node_modules/bleno/lib/hci-socket/crypto.js:37:9)
    at Object.c1 (PROJECT/node_modules/bleno/lib/hci-socket/crypto.js:22:9)
    at Smp.handlePairingRandom (PROJECT/node_modules/bleno/lib/hci-socket/smp.js:130:12)
    at Smp.onAclStreamData (PROJECT/node_modules/bleno/lib/hci-socket/smp.js:58:10)
    at emitTwo (events.js:92:20)
    at emit (events.js:172:7)
    at AclStream.push (PROJECT/node_modules/bleno/lib/hci-socket/acl-stream.js:26:10)
    at BlenoBindings.onAclDataPkt (PROJECT/node_modules/bleno/lib/hci-socket/bindings.js:201:21)
    at emitThree (events.js:97:13)

hcidump.log

bleno 0.4.2 (from git) Distribution: Debian (Kali Linux) bluez 5.47

Linux POLO-1158 4.13.0-kali1-amd64 #1 SMP Debian 4.13.4-2kali1 (2017-10-16) x86_64 GNU/Linux

Contributor guide

Tech stack
javascriptnodejs
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The crash occurs in `bleno/lib/hci socket/crypto.js` at the `swap` function where `input` is undefined. This happens during BLE pairing when `c1` is called with undefined. Review the call chain: `Smp.handlePairingRandom` calls `c1` with possibly undefined values. The fix should add a null check on `input` in `swap` or ensure the caller provides valid data. Check the hcidump.log for context, but a simple guard clause should resolve.