noble/bleno

crash during the bonding

Open

#217 opened on Aug 18, 2016

View on GitHub
 (9 comments) (0 reactions) (0 assignees)JavaScript (2,083 stars) (465 forks)batch import
help wanted

Description

Hi sandeepmistry , first of all thank for your work !

I am here because I am facing an unexpected problem when i'm trying to bonding my phone (android 6.0.1/ OP3) to my rasp on ubutu mate (LTS) with the included bluetooth adapter or with an external adapter.

this is the crash log :

`/home/****/node_modules/bleno/lib/hci-socket/crypto.js:60 var output = new Buffer(input.length); ^

TypeError: Cannot read property 'length' of undefined at swap (/home/_u/node_modules/bleno/lib/hci-socket/crypto.js:60:32) at e (/home//node_modules/bleno/lib/hci-socket/crypto.js:37:9) at Object.c1 (/home/**/node_modules/bleno/lib/hci-socket/crypto.js:22:9) at Smp.handlePairingRandom (/home/**/node_modules/bleno/lib/hci-socket/smp.js:130:12) at Smp.onAclStreamData (/home/**/node_modules/bleno/lib/hci-socket/smp.js:58:10) at emitTwo (events.js:92:20) at emit (events.js:172:7) at AclStream.push (/home/__/node_modules/bleno/lib/hci-socket/acl-stream.js:26:10) at BlenoBindings.onAclDataPkt (/home/_/node_modules/bleno/lib/hci-socket/bindings.js:198:21) at emitThree (events.js:97:13)`

Contributor guide

Tech stack
javascriptnodejs
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic Node.jsUnderstanding of Buffer in Node.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Look at the stack trace: the error originates from crypto.js line 60 in the swap function, called from c1 in the same file. The undefined input likely comes from Smp.handlePairingRandom in smp.js line 130. Investigate how the pairing random value is passed and ensure it is defined before calling c1. Possibly add a null check or ensure the data is present.