noble/bleno

crash during the bonding

Open

#217 opened on Aug 18, 2016

View on GitHub
 (9 comments) (0 reactions) (0 assignees)JavaScript (465 forks)batch import
help wanted

Repository metrics

Stars
 (2,083 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi sandeepmistry , first of all thank for your work !

I am here because I am facing an unexpected problem when i'm trying to bonding my phone (android 6.0.1/ OP3) to my rasp on ubutu mate (LTS) with the included bluetooth adapter or with an external adapter.

this is the crash log :

`/home/****/node_modules/bleno/lib/hci-socket/crypto.js:60 var output = new Buffer(input.length); ^

TypeError: Cannot read property 'length' of undefined at swap (/home/_u/node_modules/bleno/lib/hci-socket/crypto.js:60:32) at e (/home//node_modules/bleno/lib/hci-socket/crypto.js:37:9) at Object.c1 (/home/**/node_modules/bleno/lib/hci-socket/crypto.js:22:9) at Smp.handlePairingRandom (/home/**/node_modules/bleno/lib/hci-socket/smp.js:130:12) at Smp.onAclStreamData (/home/**/node_modules/bleno/lib/hci-socket/smp.js:58:10) at emitTwo (events.js:92:20) at emit (events.js:172:7) at AclStream.push (/home/__/node_modules/bleno/lib/hci-socket/acl-stream.js:26:10) at BlenoBindings.onAclDataPkt (/home/_/node_modules/bleno/lib/hci-socket/bindings.js:198:21) at emitThree (events.js:97:13)`

Contributor guide

Research direction
Inspect the swap function in crypto.js line 60. It crashes because 'input' is undefined. Trace back through c1 and Smp.handlePairingRandom to understand why 'input' is missing. Likely a missing null check or incorrect data passed during BLE pairing random event. Add a guard or fix the caller.
Tech stack
javascriptnodejs
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptNode.jsBluetooth Low Energy basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75