Allow list counters of more than 8 bits

Open
#56 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
56/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Quiet
Tech stack
cpp
Domain
computer-graphics

Research direction

Start by locating the PLY list-property serialization path and how it currently uses uchar for element counts. Review the existing PLY writing behavior and determine how a wider counter type should be selected. Done means happly can serialize lists exceeding 255 elements while preserving the expected uchar behavior for compatible mesh-like data.

Written by the indexing model from the issue text.

Description

Currently hapPLY does not allow the user to specify a type for the variable which indicates how many elements are in a list; it always uses uchar (and throws and error if the data does not fit in a uchar). Note that at least for mesh-like data, popular software only accepts uchar.

I'd like to change this. Right now I have 3D data with polytopes with more than 256 sides, so I can't use happly to serialize them as PLY files.

It seems like it should be straightforward to choose the number of bits in the counter to match the largest list.

Dominant language
C++
Stars
406
Forks
74
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nmwsharp/happly

All issues in nmwsharp/happly

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.