ninja-build/ninja

Ninja -t browse leaves socket open

Open

#465 opened on Nov 27, 2012

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (1,544 forks)batch import
bughelp wanted

Repository metrics

Stars
 (10,194 stars)
PR merge metrics
 (Avg merge 39d 3h) (10 merged PRs in 30d)

Description

Running ninja -t browse X then pressing Ctrl-C leaves the socket open. Rerunning ninja -t browse X causes a socket error.

NInja should either catch the ctrl-c and terminate python (the parent process), or support a ninja -t browsestop tool.

Note : I'm currently running 6a73d41072bafe2384aea20252c3faa6c1ceaa2a

Contributor guide

Research direction
Examine how ninja handles Ctrl C during ` t browse` and ensure the socket is properly closed on signal. Look at the browse implementation and signal handling.
Tech stack
ccpp
Domain
backendbuild system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Socket programming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70