ninja-build/ninja

Ninja -t browse leaves socket open

Open

#465 opened on Nov 27, 2012

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (10,194 stars) (1,544 forks)batch import
bughelp wanted

Description

Running ninja -t browse X then pressing Ctrl-C leaves the socket open. Rerunning ninja -t browse X causes a socket error.

NInja should either catch the ctrl-c and terminate python (the parent process), or support a ninja -t browsestop tool.

Note : I'm currently running 6a73d41072bafe2384aea20252c3faa6c1ceaa2a

Contributor guide

Tech stack
pythoncpp
Domain
clibuild system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Pythonsignal handlingsocket cleanupninja browse tool
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the Python script responsible for the 'ninja t browse' command (likely misc/browse.py). Add a signal handler for SIGINT (Ctrl C) to close the listening socket before exiting. Alternatively, implement a separate 'browsestop' command. Check the issue comments for any additional context or attempted solutions.