ninja-build/ninja

CMake build doesn't enable the use of ppoll on platforms that support it

Open

#1,821 opened on Jul 28, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (1,544 forks)batch import
help wanted

Repository metrics

Stars
 (10,194 stars)
PR merge metrics
 (Avg merge 39d 3h) (10 merged PRs in 30d)

Description

On platforms that support it, configure.py enables the use of ppoll by defining USE_PPOLL. CMake build doesn't replicate this logic which means that Ninja built with CMake is always going to use the less efficient pselect.

Contributor guide

Research direction
Inspect the CMakeLists.txt to see how platform checks are done, then add a check for ppoll similar to the one in configure.py and define USE PPOLL accordingly.
Tech stack
cpp
Domain
build system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitCMake
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60