ninja-build/ninja

Add a performance test script / "performance regression tests"

Open

#1,733 opened on Feb 6, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (1,544 forks)batch import
help wanted

Repository metrics

Stars
 (10,194 stars)
PR merge metrics
 (Avg merge 39d 3h) (10 merged PRs in 30d)

Description

Currently this is done manually by building Chromium before and after a commit. I think it would be good to have a script, which you can pass two commit hashes and a path to a Chromium source, which will then compare the -d stats result.

Maybe add the functionality to misc/measure.py?

See https://github.com/ninja-build/ninja/pull/1577#issuecomment-517797439

Contributor guide

Research direction
Extend misc/measure.py to accept two commit hashes and a Chromium source path, building each commit and comparing ' d stats' output to detect performance regressions.
Tech stack
cpp
Domain
testing
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50