ninja-build/ninja

"Installing files" step always numbered one too low on stdout (i.e. step [N/N] never shown)

Open

#1336 opened on Sep 28, 2017

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C++ (10,194 stars) (1,544 forks)batch import
bugfrontendhelp wanted

Description

I presume this is a ninja issue. If it's somehow meson's fault, I'll reopen it over there.

Using build.ninja generated by meson, I always get output like the following:

[1/5] Generating blah.gresource_c with a custom command.
[2/5] Compiling C object blah.gresource@sta/blah.gresource.c.obj.
[3/5] Linking static target libblah.gresource.a.
[4/5] Linking target blah.exe.
[4/5] Installing files.

That is: Step 5 is never shown, and the "Installing files" step is always numbered one lower than it should be, duplicating the step number of the step above it.

ninja 1.8.2 meson 0.42.1 MSYS2/MINGW64 on Windows

Contributor guide

Tech stack
cpp
Domain
build systemtooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with C++understanding of ninja build system basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the source of stdout progress messages in ninja, likely in src/build.cc or src/ninja.cc. Look for where step numbers are incremented and printed, especially for the 'Installing files' step. Check the issue comments for any hints, and test with a minimal build.ninja to reproduce the numbering offset. The fix involves ensuring the install step gets the correct number without duplicating the previous step's number.