niieani/bash-oo-framework

Not running on bash version <= 3

Open

#3 opened on Sep 9, 2015

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Shell (4,966 stars) (205 forks)batch import
enhancementhelp wanted

Description

I'm sure I could hack away at this but it seems that there's a hold up here that's preventing this from running just out of the box (directly cloned, run oo.sh) as a simple smoke test.

 [themarmot@bq bash-oo-framework] :) ./oo.sh
 /Users/themarmot/Projects/buyerquest/itops/nextgen/terraform-dev/bash-oo-framework/lib/oo-framework.sh: line 47: declare: -g: invalid option
 declare: usage: declare [-afFirtx] [-p] [name[=value] ...]
 /Users/themarmot/Projects/buyerquest/itops/nextgen/terraform-dev/bash-oo-framework/lib/oo-framework.sh: line 48: declare: -g: invalid option
 declare: usage: declare [-afFirtx] [-p] [name[=value] ...]
 /Users/themarmot/Projects/buyerquest/itops/nextgen/terraform-dev/bash-oo-framework/lib/oo-     framework.sh: line 49: declare: -g: invalid option
 declare: usage: declare [-afFirtx] [-p] [name[=value] ...]
 /Users/themarmot/Projects/buyerquest/itops/nextgen/terraform-dev/bash-oo-framework/lib/oo-framework.sh: line 16: /system/*.sh: No such file or directory

Contributor guide

Tech stack
shell
Domain
clitooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic bash scripting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Investigate how to make the framework compatible with bash versions before 4.0. The error occurs in lib/oo framework.sh lines 47-49 when using 'declare g'. Research alternatives for global variable declaration in older bash, such as using 'declare' without ' g' and ensuring variables are in global scope, or using a different approach like storing values in variables that are explicitly made global. Check the bash version at runtime and conditionally use the appropriate syntax.