niieani/bash-oo-framework

Not running on bash <= 4.1

Open

#16 opened on Feb 15, 2016

View on GitHub
 (9 comments) (1 reaction) (0 assignees)Shell (4,966 stars) (205 forks)batch import
bughelp wanted

Description

Have this error when running your-script.sh on Solaris.

$ uname -a SunOS localhost 5.11 11.2 sun4v sparc sun4v $ bash --version GNU bash, version 4.1.17(1)-release (sparc-sun-solaris2.11) $ ./your-script.sh /pkg/my/tools/bash-oo/lib/oo-bootstrap.sh: line 44: declare: -g: invalid option declare: usage: declare [-aAfFilrtux] [-p] [name[=value] ...] /pkg/my/tools/bash-oo/lib/oo-bootstrap.sh: line 45: declare: -g: invalid option declare: usage: declare [-aAfFilrtux] [-p] [name[=value] ...] /pkg/my/tools/bash-oo/lib/oo-bootstrap.sh: line 176: declare: -g: invalid option declare: usage: declare [-aAfFilrtux] [-p] [name[=value] ...] /pkg/my/tools/bash-oo/lib/oo-bootstrap.sh: line 177: declare: -g: invalid option declare: usage: declare [-aAfFilrtux] [-p] [name[=value] ...] /pkg/my/tools/bash-oo/lib/oo-bootstrap.sh: line 178: declare: -g: invalid option declare: usage: declare [-aAfFilrtux] [-p] [name[=value] ...] /pkg/my/tools/bash-oo/lib/oo-bootstrap.sh: line 190: declare: -g: invalid option declare: usage: declare [-aAfFilrtux] [-p] [name[=value] ...]

Contributor guide

Tech stack
shell
Domain
clitooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic bash scriptingfamiliarity with declare command
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue is caused by the use of `declare g` which is not supported in Bash versions <= 4.1. The error messages point to lines 44-45 and 176-178, 190 in `lib/oo bootstrap.sh`. To fix, we need to replace `declare g` with a portable alternative, perhaps by checking the Bash version with `[[ $BASH VERSINFO ge 4 ]]` or using `declare` without ` g` and ensuring global scope via other means. The fix should be tested on both older and newer Bash versions. Looking at the repository, it may require updates to all occurrences of `declare g` in the codebase.