nightwatchjs/nightwatch

`frame()` command doesn't support page object element

Open

#3655 opened on Mar 25, 2023

View on GitHub
 (7 comments) (0 reactions) (1 assignee)JavaScript (11,707 stars) (1,289 forks)batch import
buggood first issuehacktoberfest

Description

Description of the bug/issue

When I use frame() command, I expect the page object element can be used as a selector, but actually, it won't work.

Steps to reproduce

Try using frame() with a page object element.

Sample test

myPage.api.frame('@myIframe')

Nightwatch.js Version

2.6.14

Additional Information

See Discord discussion https://discord.com/channels/618399631038218240/1088668054650626058

David Burns - AutomatedTester — Yesterday at 21:33 I think this might need a bug raised. That doesn't seem right andrei — Today at 01:42 when using page objects, elements passed to commands on the .api namespace aren't resolved automatically. but we can easily add the frame() command on the main page object namespace Currently .frame() is implemented as a "protocol" command, so we will need to move it to the element-commands and update the implementation as needed. It's a relatively straightforward task.

Contributor guide

Tech stack
javascriptnodejs
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Nightwatch.js basicsPage object modelJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the existing implementation of `frame()` as a protocol command (likely in `nightwatch/lib/api/commands/` or similar). Look at how other element commands like `click` are implemented as element commands, including how they resolve page object elements. Then modify `frame()` to follow that pattern. Check the Discord discussion for additional context.