nicolaslopezj/searchable

Laravel 5.2 Support

Open

#98 opened on Jan 8, 2016

View on GitHub
 (14 comments) (0 reactions) (0 assignees)PHP (1,999 stars) (292 forks)user submission
help wanted

Description

Pagination not working... Gives error if search query returns zero results : ErrorException in Collection.php line 1040: Undefined offset: 0

Contributor guide

Tech stack
phplaravel
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
PHP knowledgeLaravel basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
The error occurs in Collection.php line 1040 with 'Undefined offset: 0' when pagination is attempted on an empty search result. Investigate the package's pagination logic in the searchable trait (likely in src/SearchableTrait.php) and how it handles empty collections. Check if there is a missing check for an empty result set before calling paginate. Also review the issue comments for any suggested fixes or workarounds.