nicfit/eyeD3

allow to set multiple TCON frames

Open

#296 opened on Dec 15, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (487 stars) (58 forks)batch import
featurehelp wanted

Description

Setting multiple TCON frames logs all modification, but then only the last frame is written

$ eyeD3 --text-frame=TCON:Rock --text-frame=TCON:Ballad \
     --text-frame=TCON:Pop /tmp/1.mp3

Setting b'TCON' text frame to 'Rock'
Setting b'TCON' text frame to 'Ballad'
Setting b'TCON' text frame to 'Pop'

The situation is different if the file had multiple TCON frames in origin. Only the first is modified while others frames are kept.

Further info in debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=887405

Tested with eyed3 0.8.7 and python 3.6.7.

Contributor guide

Tech stack
python
Domain
clitooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of ID3 tagsPython programming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Investigate the code that handles writing multiple TCON frames. The issue states that when multiple TCON frames are set via command line, only the last one is written. Look at the relevant functions in eyeD3 that process and write text frames, possibly in the tag writing module. Check the linked Debian bug for additional context. Focus on how frames are collected and how duplicate frames are handled. Consider adding support for multiple frames of the same type or modifying the existing logic to write all provided frames.