Github Actions Workflows should be updated to use Node.js 20

Open
#2,039 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
74/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Active
Tech stack
github-actions
Domain
ci-cd

Research direction

Start with the .github/workflows/github_actions_aws_*.yml files and inspect every actions/checkout and codecov/codecov-action step. Read the checkout v4 and Codecov v4 READMEs before updating their versions and any changed arguments. Done means the workflows use Node.js 20-compatible actions and coverage uploads continue to work.

Written by the indexing model from the issue text.

Description

build
Description of issue

Our nimibot runner summaries are showing annotations:

system_test (niscope)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, codecov/codecov-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

We should update our configuration to use Node.js 20, before support for Node.js 16 is dropped entirely.

The configuration for this can be found in .github\workflows\github_actions_aws_*.yml (the * is a wildcard not part of a filename).
The steps look like:

    steps:
      - name: checkout repository
        uses: actions/checkout@v3
      - name: upload coverage
        uses: codecov/codecov-action@v3
  • For codecov-action, the issue was addressed in the v4 release
    • Arguments to the action have changes, so see the README
    • There's some mixed messaging that suggests we could go back to Tokenless uploading (PRs made from forks to the upstream public repos will support tokenless), but based on my reading of things, I don't think that's the case. It'll give us intermittent upload failures, again
  • For checkout, the issue was addressed in the v4 release
Dominant language
Python
Stars
128
Forks
110
Avg merge
5d 14h
Merged PRs (30d)
10

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ni/nimi-python

All issues in ni/nimi-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.