ni.measurements.* packages and ni.datamonikers.* packages should be x-plat

Open Beginner friendly
#161 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
63/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
documentation, tooling

Research direction

Inspect the README.md and pyproject.toml files for the ni.measurements.* and ni.datamonikers.* packages. Update their supported operating systems to Windows and POSIX, then verify that the package metadata and documentation consistently advertise the expected support; consider the optional init behavior separately.

Written by the indexing model from the issue text.

Description

bug triage

Bug Report

  • The README.md at the root of each of these packages lists Windows as the only supported operating system.
  • The pyproject.toml only lists Windows as the supported OS

These packages should be windows + posix

Repro or Code Sample

None - see aforementioned files.

Expected Behavior

The packages should support Windows and POSIX

Possible Solution

Update the README.md, update pyproject.toml
Optional: raise an error from __init__ if the grpc channel is not given and we're not on Windows. Other OS do not have DiscoveryClient support (yet), but the exported packages should still claim POSIX/Linux support.

AB#3327918

Dominant language
Python
Stars
7
Forks
2
Avg merge
1d 18h
Merged PRs (30d)
3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ni/ni-apis-python

All issues in ni/ni-apis-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.