nfl/react-helmet

Unexpected comma in title

Open

#408 opened on Oct 9, 2018

View on GitHub
 (9 comments) (6 reactions) (0 assignees)JavaScript (706 forks)batch import
bughelp wanted

Repository metrics

Stars
 (17,167 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Similar to #286, I continue to see a comma in the title of pages of my Gatsby app and seems to only be a problem if there's an expression in the title. A reproduction of this issue can be seen in the following branch.

https://github.com/corydeppen/gatsby-8655-example/tree/react-helmet-comma

Contributor guide

Research direction
Clone the reproduction branch, inspect the title expression usage, and trace the code in react helmet that sets the title to identify where the comma is introduced.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75