nfl/react-helmet

Unexpected comma in title

Open

#408 opened on Oct 9, 2018

View on GitHub
 (9 comments) (6 reactions) (0 assignees)JavaScript (17,167 stars) (706 forks)batch import
bughelp wanted

Description

Similar to #286, I continue to see a comma in the title of pages of my Gatsby app and seems to only be a problem if there's an expression in the title. A reproduction of this issue can be seen in the following branch.

https://github.com/corydeppen/gatsby-8655-example/tree/react-helmet-comma

Contributor guide

Tech stack
reactjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the reproduction branch at https://github.com/corydeppen/gatsby 8655 example/tree/react helmet comma to reproduce the issue. Examine the React Helmet source code, particularly how the title prop is processed and concatenated, to identify where an extra comma is inserted. Check if the bug is related to how expressions in the title are handled, possibly in the side effects or rewrite methods.