nfl/react-helmet

Move typespec to this repo

Open

#358 opened on Feb 25, 2018

View on GitHub
 (1 comment) (3 reactions) (0 assignees)JavaScript (17,167 stars) (706 forks)batch import
enhancementgood first issuehelp wanted

Description

Is there any reason why we can't move the typespec from https://github.com/DefinitelyTyped/DefinitelyTyped to this repo so we do not have to deal with two packages.

We could copy that into this package and add "types": "./lib/main.d.ts" in the package.json

Contributor guide

Tech stack
typescriptreact
Domain
developer experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with TypeScript type definitionsUnderstanding of npm package.json
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
First, find the existing type definitions in DefinitelyTyped for react helmet (https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react helmet). Copy the relevant .d.ts files into this repo, e.g., into a 'types' directory. Then, update package.json by adding a 'types' field pointing to the new declaration file (e.g., "./lib/main.d.ts"). Ensure the types align with the current API. Check the issue comments for any maintainer feedback.