nfl/react-helmet

onChangeClientState not executing

Open

#328 opened on Oct 23, 2017

View on GitHub
 (2 comments) (8 reactions) (0 assignees)JavaScript (17,167 stars) (706 forks)batch import
bughelp wanted

Description

It appears that after v5.0.0 onChangeClientState has some odd behaviour - its seemingly overridden by nested <Helmet /> usage or something else that results in it not executing when there are is more than one use of it. This wasn't the case before and would executed on the component it was specified for as well as all others.

This is useful for running code after Helmet has injected all the specified items - componentDidMount will sometimes return null when querying the DOM for items that should have been injected so we cannot use this.

Contributor guide

Tech stack
reactjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
ReactJavaScriptcomponent lifecycle
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
Start by examining the react helmet source code, focusing on the componentWillMount method and the onChangeClientState implementation. Look at the git log for changes between v4 and v5 to identify what changed. Read the two comments on the issue for any additional hints. Consider writing a minimal reproduction in CodeSandbox to isolate the bug.