nextcloud/server

Plural missing on CalDAV Activity when creating multiple Calendar events

Open

#5528 opened on Jun 24, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)PHP (34,953 stars) (4,865 forks)batch import
1. to develop32-feedbackbugfeature: activity and notificationfeature: caldavfeature: language/translations (l10n/i18n)good first issuepapercut

Description

Steps to reproduce

  1. Create multiple events around the same time on Nextcloud Calendar
  2. Look at your Activities
  3. An activity stating "You created event Event 1, Event 2..."

Expected behaviour

If multiple events are created, activity should read as "You created events Event 1, Event 2..."

Actual behaviour

The word "event" is not plural.

Server configuration

Nextcloud 12

Operating system: N/A

Web server: N/A

Database: N/A

PHP version: N/A

Nextcloud version: 12

Updated from an older Nextcloud/ownCloud or fresh install: N/A

Where did you install Nextcloud from: git source

Client configuration

Browser: Noticed on Nextcloud-dev Android client, but client agnostic

Relevant code seems to be here: https://github.com/nextcloud/server/blob/master/apps/dav/lib/CalDAV/Activity/Provider/Event.php#L89

Contributor guide

Tech stack
php
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic PHP knowledgeUnderstanding of Nextcloud activity system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue is in the file `apps/dav/lib/CalDAV/Activity/Provider/Event.php` around line 89. The string 'event' needs to be pluralized to 'events' when multiple events are created. Look at the method that constructs the activity message; it likely receives a count or an array of events. Adjust the string to use a conditional plural form, e.g., using a ternary operator or a translation function that supports pluralization. Test by creating multiple events and checking the activity output.