nextcloud/server

Enable usage of svg favicons and remove imagick from iconbuilder

Open

#36,607 opened on Feb 8, 2023

View on GitHub
 (11 comments) (4 reactions) (0 assignees)PHP (34,953 stars) (4,865 forks)batch import
1. to developfeature: theminghelp wantedtechnical debt

Description

This allows us to get rid of using imagick in iconbuilder of the theming app, which in return allows us to not enforce this requirement anymore since gd and imaginary can be used for all other tasks.

Julius found this: https://www.leereamsnyder.com/blog/favicons-in-2021#safari-does-not-fully-support-svg-icons

cc @juliushaertl

Contributor guide

Tech stack
php
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PHPNextcloud server architectureTheming app concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
The issue involves enabling SVG favicons in the iconbuilder of the theming app and removing the imagick dependency. The code is likely in the 'theming' app directory. Review the linked blog post about Safari SVG favicon support. Check comments for any ongoing work or additional requirements. Ensure that the replacement using gd and imaginary handles all icon types. No linked PRs exist, so implement the changes from scratch, testing with various browsers.