nextcloud/server

Support SVG Favicons

Open

#28,640 opened on Aug 29, 2021

View on GitHub
 (7 comments) (7 reactions) (0 assignees)PHP (4,865 forks)batch import
1. to developenhancementfeature: theminggood first issue

Repository metrics

Stars
 (34,953 stars)
PR merge metrics
 (Avg merge 20d) (627 merged PRs in 30d)

Description

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe. SVG Favicons are supported by a wide variety of browsers. As with the other images supported by the Theming app, it would be preferable to avoid converting SVG images used as favicons and instead leaving them as is.

Describe the solution you'd like SVG Favicons to not be converted and instead used directly.

Describe alternatives you've considered n/a

Additional context Features such as light/dark theme support require SVG images to utilise CSS' prefers-color-scheme feature.

Contributor guide

Research direction
Investigate the Theming app code to see how favicons are generated and identify where SVG conversion occurs; then modify to skip conversion for SVG files.
Tech stack
phpcsshtml
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPHP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80