nextcloud/server

occ config:system:set should return a different output when unchanged

Open

#24,300 opened on Nov 23, 2020

View on GitHub
 (3 comments) (1 reaction) (0 assignees)PHP (4,865 forks)batch import
1. to developenhancementfeature: occgood first issue

Repository metrics

Stars
 (34,953 stars)
PR merge metrics
 (Avg merge 20d) (627 merged PRs in 30d)

Description

Steps

  1. Run occ config:system:set mail_smtpmode --value mail_smtpmode
  2. Run it again

Expected result

An output with "Already set"

Actual result

Exact same output.

Version

Nextcloud 20.0.2

Context

When using tools like Ansible, one might want to know whether a value was changed or not to be able to set the changed_when clause there based stdout result.

Also needs to be applied to the other occ config:*:set commands.

Contributor guide

Research direction
Locate the command handler for `config:system:set` in the codebase and add a check comparing old and new values. If unchanged, output 'Already set' instead of repeating the success message.
Tech stack
php
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70