nextcloud/server

Option to disable showing system email in avatars' contacts menu

Open

#23,172 opened on Oct 4, 2020

View on GitHub
 (2 comments) (6 reactions) (0 assignees)PHP (4,865 forks)batch import
1. to developenhancementfeature: contacts menugood first issueprivacy

Repository metrics

Stars
 (34,953 stars)
PR merge metrics
 (Avg merge 20d) (627 merged PRs in 30d)

Description

Steps

  1. Setup a NC instance
  2. Create accounts for many external people with email so they can receive an invitation and notifications
  3. Create a Talk conversation with all people
  4. Click on the three dots on a person's avatar in the participant list

Expected result

In the case of external people, we should not see their email address.

Actual result

There's an option to see and click an email address

I suggest to add an option to remove the EmailProvider in config.php or other. A quick hack is to remove https://github.com/nextcloud/server/blob/stable20/lib/private/Contacts/ContactsMenu/ActionProviderStore.php#L88 in config.php

Version

Nextcloud 20

@rullzer @ChristophWurst FYI

Contributor guide

Research direction
Add a new config.php option to disable the EmailProvider in the contacts menu. Refer to ActionProviderStore.php and modify it to check the config option before registering the provider.
Tech stack
php
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPNextcloud development setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65