nextcloud/server

Pressing escape on the sharing note should cancel and not save

Open

#18,935 opened on Jan 16, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)PHP (4,865 forks)batch import
1. to developenhancementfeature: sharinggood first issueneeds reviewpapercut

Repository metrics

Stars
 (34,953 stars)
PR merge metrics
 (Avg merge 20d) (627 merged PRs in 30d)

Description

We needed https://github.com/nextcloud/nextcloud-vue/pull/819 after https://github.com/nextcloud/server/pull/18894

Contributor guide

Research direction
Examine the sharing note component in the Vue library and the server side handling to understand the current save on escape behavior and implement a cancel action.
Tech stack
phpvue
Domain
frontendbackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPHPVue.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75