nextcloud/server

Pressing escape on the sharing note should cancel and not save

Open

#18935 opened on Jan 16, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)PHP (34,953 stars) (4,865 forks)batch import
1. to developenhancementfeature: sharinggood first issueneeds reviewpapercut

Description

We needed https://github.com/nextcloud/nextcloud-vue/pull/819 after https://github.com/nextcloud/server/pull/18894

Contributor guide

Tech stack
vuejavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with Vue.jsbasic understanding of Nextcloud's sharing UI
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue references PR #819 in nextcloud vue (https://github.com/nextcloud/nextcloud vue/pull/819) and PR #18894 in nextcloud/server (https://github.com/nextcloud/server/pull/18894). The fix likely involves modifying the sharing note component in nextcloud vue to handle the Escape key pressed event to cancel saving. Check the referenced PRs for implementation details and any related discussions. The issue is clear and localized, making it suitable for a newcomer with basic Vue knowledge.