nextcloud/server

Cleanup Server.php (aliases & services)

Open

#12,225 opened on Nov 2, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)PHP (4,865 forks)batch import
1. to developgood first issuetechnical debt

Repository metrics

Stars
 (34,953 stars)
PR merge metrics
 (Avg merge 20d) (627 merged PRs in 30d)

Description

As discussed with @MorrisJobke

We regsiter a lot of plain text aliases like https://github.com/nextcloud/server/blob/9319d557a4b1156d82d824cdb1b7d6f07ad3fbde/lib/private/Server.php#L182

They should all die. Services should be queries properly using their servicename.

Ideally we also remove as much simple wrappers as possible like: https://github.com/nextcloud/server/blob/9319d557a4b1156d82d824cdb1b7d6f07ad3fbde/lib/private/Server.php#L256-L258 The DI can handle that all perfectly by itself when it is actually needed.

Contributor guide

Research direction
Identify all plain text aliases and simple wrapper methods in lib/private/Server.php. For each, find the corresponding service interface and replace the alias/wrapper with a direct query to the service container (e.g., using `$this >get() or `$c >get()`). Ensure the same behavior is preserved by testing.
Tech stack
php
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPDependency InjectionGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75