nextcloud/richdocuments

Crash when nextcloud is inside an iframe

Open

#3,209 opened on Sep 30, 2023

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)JavaScript (145 forks)auto 404
1. to developbuggood first issue

Repository metrics

Stars
 (452 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the bug When Nextcloud is inside an iframe, the new code for a dark interface crashes the richdocuments app.

To Reproduce Steps to reproduce the behavior:

  1. Have nextcloud in an iframe
  2. Open a richdocument file

Expected behavior The document should open

Client details:

  • OS: archlinux
  • Browser firefox
  • Version: 118.0
  • Device: desktop

Server details

Operating system: Debian 11

Web server: Apache

Database: Mysql

PHP version: 8.2

Nextcloud version: 27.1.1

Version of the richdocuments app 8.2

Version of Collabora Online 22.05.12.2

Browser log

The javascript console log :

Permission denied to access property "document" on cross-origin object

Contributor guide

Research direction
Investigate the use of 'parent.document.body.dataset' in src/helpers/coolParameters.js lines 35-36. When inside an iframe, accessing parent.document may fail due to cross origin restrictions. Consider checking if the parent is same origin or using a different method to detect dark mode. Look for alternatives like communicating with the parent via postMessage or checking a cookie/localStorage set by the parent.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptiframe security
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70