nextcloud/nextcloudpi

Modsecurity prevents update of contacts

Open

#1,061 opened on Jan 18, 2020

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)Shell (320 forks)auto 404
bughas-updateshelp wantedneeds verification

Repository metrics

Stars
 (2,920 stars)
PR merge metrics
 (PR metrics pending)

Description

The default configuration of NCP with modsecurity seems to have an issue when handling vcard files.

Setup: current docker instance of NCP with modsecurity enabled, latest updates

Steps to reproduce:

  1. create new contact
  2. save contact (successful)
  3. change contact data
  4. request error 500 on saving the contact
  5. data is lost after site refresh

Steps 3-5 are successfull with disabled modsecurity.

Solution:

  • create exception for addressbooksync

The corresponding logfile/line: [Sat Jan 18 17:39:21.463016 2020] [:error] [pid 23201:tid 1817326624] [client xxxxxx] [client xxxxxxx] ModSecurity: XML parser error: XML: Failed parsing document. [hostname "xxxxxxxx"] [uri "/remote.php/dav/addressbooks/users/xxxxxx/xxxxxx/xxxxxx-2DA4-4988-8FC6-xxxxxxxxxx.vcf"] [unique_id "XiNCyZLwCYQ4v2CWduyWOQAAShg"]

Contributor guide

Research direction
Create a ModSecurity rule exception to allow vcard files to be updated without triggering the XML parser error.
Tech stack
shelldocker
Domain
backendinfrastructure
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ModSecurityNextcloudDocker
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75