nextcloud/android

status dialog: not able to set only "icon" / only "clear at"

Open

#9,855 opened on Feb 17, 2022

View on GitHub
 (3 comments) (1 reaction) (0 assignees)Java (3,752 stars) (1,719 forks)batch import
approvedbugfeature: statusgood first issue

Description

Steps to reproduce

  1. set only icon or only clear at without to enter status message
  2. click set staus

Expected behaviour

  • icon or clear at are set

Actual behaviour

  • icon or clear at not set

Environment data

Nextcloud app version: 3.19.0

solution

api seems to set single modification for icon or "clear at" only if status message is not empty (must be at least whitespace)

see android talk commit https://github.com/nextcloud/talk-android/pull/1668/commits/a89c5952fa2747c8877c7882a6106311257722bf

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Android development basicsJava
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue is about setting only icon or clear at without a status message in the Nextcloud Android app. The expected behavior is that setting just the icon or clear at should work, but the API currently requires a non empty status message (at least whitespace). A similar fix was applied in the Android Talk app: see commit a89c5952fa2747c8877c7882a6106311257722bf. The solution likely involves modifying the API call in the status dialog to handle cases where status message is empty. Look at the status dialog implementation in the Nextcloud Android repository for the relevant network request code.
status dialog: not able to set only "icon" / only "clear at" · nextcloud/android#9855 | Good First Issue