Check `NetworkRequest#mDestroyed` before each network request?

Open Beginner friendly

#563 opened on May 23, 2023 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 2/5
Estimated time: 1-3 hours
Newbie friendliness: 72/100

Issue type: Bug
Clarity: Mostly clear
Activity status: Active
Tech stack: android, java
Domain: mobile

Research direction

Start at AidlNetworkRequest#performNetworkRequestV2 and compare it with the existing NetworkRequest#mDestroyed check performed during connect. Verify that calling close() before a request is detected at the start of the operation and results in a meaningful IllegalStateException rather than a later null-context failure.

Written by the indexing model from the issue text.

Description

I recently ran into an issue while trying to make a network request on an NextcloudAPI instance, on which I called close() before.

Of course, it failed, but at an odd place, that I didn't expected (I think context was null at some place).

This made me wondering why we do check for NetworkRequest#mDestroyed when connecting, but not before each request. Wouldn't make it sense to add this check also at the beginning of AidlNetworkRequest#performNetworkRequestV2 and throw a more meaningful IllegalStateException or something alike?

cc @David-Development

Dominant language: Java
Stars: 74
Forks: 36
Avg merge: 1d 6h
Merged PRs (30d): 15

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

[Bug][UI] Change the method of opening the Action Detail Open

Difficulty 2/5 1-3 hours Newbie friendliness 65/100

Netcracker/qubership-integration-platform#913 · Opened Sep 23, 2026
SEC-CORS-006 declares MEDIUM but can only emit HIGH or LOW Open

bug

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

jdubois/boot-ui#1100 · Opened Sep 23, 2026
build-scan-xunit: accept ISO offset timestamps in test reports Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

elastic/gradle-plugins#157 · Opened Sep 23, 2026
OpenAPI document marks optional request body of `PUT /api/users/me` as required Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

cryptomator/hub#497 · Opened Sep 23, 2026
No test covers the claim that only the last command's state is checked Open

Difficulty 2/5 1-3 hours Newbie friendliness 75/100

johanhaleby/occurrent#1120 · Opened Sep 23, 2026

More Java issues