next-exp/IC

Reorganize, simplify and clean up fixtures

Open

#913 opened on Oct 30, 2024

View on GitHub
 (0 comments) (0 reactions) (1 assignee)Python (77 forks)auto 404
easygood first issuehelp wantedtesting

Repository metrics

Stars
 (10 stars)
PR merge metrics
 (PR metrics pending)

Description

We use many fixtures. Most of them are thrown into invisible_cities/conftest.py without thinking much. Let's reorganize them following the following logic:

  • If they are used only in one file, move them to that file
  • If they are used only in one folder, move them to the conftest.py file in that folder
  • Otherwise, keep them in invisible_cities/conftest.py

Moreover, some of those fixtures are monstrous. Let's try to simplify them or replace them with test files whenever possible to keep things readable.

Contributor guide

Research direction
Identify fixtures used only in one file and move them to that file; identify fixtures used only in one folder and move them to that folder's conftest.py; otherwise keep them in the root conftest.py. For monstrous fixtures, consider simplifying them or replacing with test files.
Tech stack
python
Domain
testing qa
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Pythonpytest
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70