nestjs/azure-storage

Add forRootAsync for configuration via configService

Open

#36 opened on Sep 24, 2019

View on GitHubContributor guide
 (3 comments) (2 reactions) (1 assignee)TypeScript (38 forks)github user discovery
Hacktoberfesteffort1: hoursgood first issuescope: nestjs

Repository metrics

Stars
 (88 stars)
PR merge metrics
 (Avg merge 4h 43m) (9 merged PRs in 30d)

Description

I'm submitting a...

Current behavior

Currently, it's only possible to instantiate the module via the .withConfig method. It is not possible to inject a service into this method, so it is impossible to use a config service for the module instantiation.

Expected behavior

Enable both the .withConfig method and a factory-pattern method, that allows dependency injection.

What is the motivation / use case for changing the behavior?

I don't want to use process.env variables as all my config logic is inside a config module. It is possible to override this behavior by manually injecting all config values into process.env, but this seems like a bad choice.

Environment

Contributor guide

Research direction
Study existing NestJS modules (e.g., @nestjs/typeorm) for forRootAsync pattern, then implement a similar factory method in the Azure Storage module that allows injecting services via ConfigService.
Tech stack
typescriptnodejs
Domain
backendapi
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
NestJSTypeScriptDependency Injection
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60