nervosnetwork/ckb

Ensure that the `IntegrationTestRPC::truncate` functionality works properly in non-dev mode

Open

#4,230 opened on Nov 13, 2023

View on GitHub
 (2 comments) (0 reactions) (1 assignee)Rust (1,210 stars) (260 forks)user submission
good first issuep:should-havestalet:enhancement

Description

Feature Request

Currently, the IntegrationTestRPC::truncate RPC is disabled in non-dev mode, and it doesn't work well in non-dev mode. https://github.com/nervosnetwork/ckb/blob/98678a812023cfbbae363912995e4d3c3eb51458/rpc/src/service_builder.rs#L158-L163

Consider adding the truncate feature as a subcommand in CKB, similar to ckb reset-data. This would be beneficial for non-dev mode usage.

Contributor guide

Tech stack
rust
Domain
backendblockchaincli
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
RustCKB node architectureCLI command implementationRPC concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Start by examining the referenced code in rpc/src/service builder.rs (lines 158-163) to understand how truncate is currently disabled. Then look at the existing `ckb reset data` subcommand implementation as a pattern. The goal is to add a new subcommand that enables truncate functionality in non dev mode, following similar safety and design patterns. Review any comments or discussions in the issue for additional context.