Remove dead external_storage_fallback_threshold plumbing from localnet TEE cluster scripts

Open Beginner friendly
#3,538 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
86/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Quiet
Tech stack
shell
Domain
documentation, tooling

Research direction

Start with localnet/tee/scripts/rust-launcher/node.conf.testnet.toml.tpl, deploy-tee-cluster.sh, and how-to-run-deploy-tee-cluster.md, then inspect the three referenced locations for the obsolete variable. Done means the template no longer renders it, the script no longer defaults or requires it, and the deployment guide no longer documents it.

Written by the indexing model from the issue text.

Description

tech-debt
Background

#3533 removed the external_storage_fallback_threshold field from NearInitConfig (state sync is now decentralized/Peers). The localnet TEE cluster tooling still writes and requires it:

  • localnet/tee/scripts/rust-launcher/node.conf.testnet.toml.tpl:22 — renders external_storage_fallback_threshold = ${EXTERNAL_STORAGE_FALLBACK_THRESHOLD}
  • localnet/tee/scripts/rust-launcher/deploy-tee-cluster.sh:828,869 — defaults the env var to 100 and hard-requires it before rendering the template
  • localnet/tee/scripts/rust-launcher/how-to-run-deploy-tee-cluster.md:253-261 — documents the env var

Since NearInitConfig has no #[serde(deny_unknown_fields)], the rendered field is now silently ignored — functionally harmless, but the template/script/docs mislead anyone running the localnet TEE cluster. (Localnet disables state sync entirely, so the knob was doubly moot there.)

Acceptance Criteria
  • Drop external_storage_fallback_threshold from node.conf.testnet.toml.tpl.
  • Remove the EXTERNAL_STORAGE_FALLBACK_THRESHOLD default/requirement from deploy-tee-cluster.sh.
  • Remove the env-var docs from how-to-run-deploy-tee-cluster.md.
Resources & Additional Notes
  • Follow-up from #3533 (review). Related: #3526.
Dominant language
Rust
Stars
44
Forks
42
Avg merge
1d 13h
Merged PRs (30d)
111

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from near/mpc

All issues in near/mpc

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.