ndmitchell/hlint

bad suggestion for "redundant section"

Open

#1,257 opened on Jun 8, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Haskell (208 forks)batch import
good first issue

Repository metrics

Stars
 (1,594 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

the following function has the suggestion included however following the hint results in it not compiling

weirdEq :: (Int, Int) -> (Int, Int) -> Bool
weirdEq (_, 1) (_, 1) = True
weirdEq a b = ((==) `on`) snd a b

Suggestion: Redundant section
Found:
  ((==) `on`) snd
Perhaps:
  (==) `on` snd

v3.3.1 windows and linux

Contributor guide

Research direction
Investigate the 'redundant section' suggestion for ((==) `on`) snd. Determine why removing the parentheses causes a compile error, and propose a fix to avoid the false positive.
Tech stack
haskell
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Haskell
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75