nchutchind/cordova-plugin-streaming-media

Problem with picture in picture on iOS (PIP)

Open

#169 opened on Jan 24, 2019

View on GitHub
 (7 comments) (1 reaction) (0 assignees)Java (392 stars) (285 forks)batch import
bughelp wantedpull-request-welcome

Description

What version of Streaming-Meda-Cordova-Plugin are you using? 2.2.0

What version of Cordova are you using? 8.0.0

What devices are affected? all iPads

Please describe the issue in detail, with relevant code samples When the user has started the video on an iPad its possible that he taps on the PiP button to play video in a small window hovering over my app (Picture in Picture, floating video). This small window has 3 buttons: Play/Stop, Close and Restore the video to fullscreen.

Unfortunately the restore button just closes the small video window and does NOT restore the full screen video. If the user has switched to another app in the mean time, my app is restored successfully but the video window also closes.

I don't know what happens here exactly. I don't get any callback that something happened with the video and can't do anything about it.

As I understand the iOS AVPlayerViewController has an option to disable Picture-In-Picture but this option isn't available in this plugin.

I have seen in past issues, that there is a problem that AVPlayerViewController doesn't has a callback when the user closes the video, but can you maybe make this option for this plugin so that the user can't enter PiP at all?

Contributor guide

Tech stack
objective c
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
iOS development knowledgeObjective C basicsCordova plugin structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Look for the iOS implementation files of the plugin, likely named StreamingMedia.m or similar. The issue suggests adding a property to disable PiP by setting `allowsPictureInPicturePlayback` to NO on the AVPlayerViewController. Review the plugin's header and implementation to expose this property via a configuration option.