Fix string NA vs NA in MANC for cf_meta

Open Beginner friendly
#57 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
64/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
r
Domain
data

Research direction

Start by tracing the cf_meta call used with cf_ids in the MANC dataset path. Reproduce the example with datasets "manc", "malecns", and "yakubavnc", then inspect how string NAs and empty strings are represented in the returned fields. Done means both forms are converted to actual R NA values in the output.

Written by the indexing model from the issue text.

Description

In MANC, there are string NAs, instead of actual NA (there are also "" that I've come across).
Could the string NAs and empty strings be replaced by NA so the output is already cleaned up?

 cf_ids('/type:(pIP10|pMP2).*',
datasets = c("manc", "malecns", "yakubavnc")))

testna |> count(type, lineage, dataset)
   type lineage   dataset n
1 pIP10      NA      manc 2
2 pIP10    <NA>   malecns 2
3 pIP10    <NA> yakubavnc 2
4  pMP2      NA      manc 2
5  pMP2    <NA>   malecns 2
6  pMP2    <NA> yakubavnc 2
Dominant language
R
Stars
11
Forks
4
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from natverse/coconatfly

All issues in natverse/coconatfly

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.