Typo in time-to-impact Trick_Tutorial_Review.[pdf, ppt]

Open Beginner friendly
#2,160 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
75/100
Issue type
Documentation
Clarity
Mostly clear
Activity status
Active
Domain
documentation

Research direction

Start with the Trick_Tutorial_Review.[pdf, ppt] slide deck and inspect the time-to-impact equations on slides 6 and 9. Compare them with the correct implementation in cannon_analytic.c, then check the other tutorial slides for the same omission. Done means the missing ay term is corrected wherever needed and the deck renders with the intended equations.

Written by the indexing model from the issue text.

Description

There is a missing factor of graviational acceleration in the Trick Tutorial slide deck. The second term under the radical is missing the "ay" term from the correct solution to the quadratic formula. If the initial vertical position is nonzero, this would produce incorrect results for time to impact.

Image

the errors are at least on slides 6 and 9, but perhaps this is also on other slides in the tutorial documentation.

I also checked cannon_analytic.c and it appears to be correct in that file. I don't see a "cannon.c" as described in the tutorial.

Dominant language
C++
Stars
171
Forks
73
Avg merge
4d 6h
Merged PRs (30d)
16

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nasa/trick

All issues in nasa/trick

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.