apps/sbn/fsw/platform_inc/sbn_types.h and sbn_platform_cfg.h have #include statements that are outside conditional macro style include guard.
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- c
- Domain
- embedded-iot
Research direction
Start with fsw/platform_inc/sbn_types.h and fsw/platform_inc/sbn_platform_cfg.h at the linked line 19 locations, comparing each include guard. Confirm the include placement satisfies the static code analysis rule, then rerun the relevant analysis or project checks; done means both headers pass without the reported guard warning.
Written by the indexing model from the issue text.
Description
Our static code analysis flagged both sbn_types.h and sbn_platform_cfg.h because #include "cfe.h" is not placed within the #ifndef, #define, #endif guard against multiple inclusion.
- Dominant language
- C
- Stars
- 43
- Forks
- 42
- Avg merge
- 13d 20h
- Merged PRs (30d)
- 2
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from nasa/SBN
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Similar issues
-
level/task module/gcp type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
Difficulty 1/5 Under an hour Newbie friendliness 86/100
hapostgres/pg_auto_failover#1190 ·
-
docs
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
P3 sonic-vpp
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
sonic-net/sonic-buildimage#29662 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 94/100
spack/spack-packages#6586 ·