nasa/OnAIR

Plugins do not currently restrict same names either within type or between types

Open

#163 opened on Nov 8, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (28 forks)auto 404
help wantedquestion

Repository metrics

Stars
 (105 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently using the same name plugin within a plugin dict silently overwrites the previous definition. This would result in user frustration as it may be unclear what is wrong in their config file.

Currently using the same name plugin between types is allowed and does create two distinct objects (all 4 types are held in their own list). Also, the high_level_data does separate results by type, {'vehicle_rep': {'same_name':{}}, 'learning_systems': {'same_name':{}}, 'planning_systems': {'same_name':{}}, 'complex_systems':{'same_name':{}}}. However this could be confusing using outputs or referring to plugins by name, especially if a plugin ignores the keys and directly accesses values of the high_level_data.

Should it stay the same (not recommended), accept but warn users, or deny one or both of these operations?

Contributor guide

Research direction
Investigate how plugins are registered, specifically in the plugin dictionary and across types. Consider implementing a warning or enforcement of unique names.
Tech stack
python
Domain
backendai
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70