napalm-automation/napalm

Shutdown BGP neighbours are not parsed correctly

Open

#461 opened on Oct 24, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (2,145 stars) (553 forks)batch import
buggood first issueios

Description

Description of Issue/Question

If a BGP neighbour is Admin shutdown, the key "is_enabled" has value True instead of False

Did you follow the steps from https://github.com/napalm-automation/napalm#faq

  • [* ] Yes
  • No

napalm-ios version

napalm-ios==0.6.2

IOS version

Cisco IOS Software, s2t54 Software (s2t54-ADVIPSERVICESK9-M), Version 15.2(1)SY1a, RELEASE SOFTWARE (fc6)

Steps to Reproduce the Issue

In case the bgp neighbour 10.1.1.1 is shutdown, the output from "show bgp all summary" is: .. 10.1.1.1 4 65001 0 0 1 0 0 never Idle (Admin) ... but the "Admin" string is not parsed correctly and the result is:

"10.1.1.1": { ... "is_enabled": true, "is_up": false,

The problem is in the line 1198 inside the ios.py which strips the "Admin" string because it is the 11th element inside the list: fields = line.split()[:10]

and so it never gettes into "state_prefix" variable for later check:

if '(Admin)' in state_prefix: is_enabled = False else: is_enabled = True

if I for example remove the [:10] and concatenate last two strings Idle and (Admin), the it works fine:

fields = line.split() if len(fields) > 10: fields[9] = fields[9] + fields[10] fields = fields[:10]

"10.1.1.1": {... "is_enabled": false, "is_up": false,

Moved from https://github.com/napalm-automation/napalm-ios/issues/161

Contributor guide

Tech stack
python
Domain
infrastructure
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the file ios.py around line 1198 where the output of 'show bgp all summary' is parsed. The current code splits the line and takes only the first 10 fields, which cuts off the '(Admin)' suffix. Modify the splitting logic either by removing the slice or by concatenating fields[9] and fields[10] when the line has more than 10 fields, as suggested in the issue. Ensure that the 'is enabled' field is set to False when '(Admin)' is present. No linked PR or comments exist, so the fix can be implemented directly.