napalm-automation/napalm

ios: get_interfaces() last_flap - not implemented

Open

#1,006 opened on Jun 25, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (2,145 stars) (553 forks)batch import
featuregood first issuehelp wantedios

Description

Description of Issue/Question

Drivers do not have last_flap attribute calculated for get_interfaces(). I believe a good source of this would be the "last input / last output / last output hang" data that is seen via a show interface command typically. In fact it might make better sense to add these 3 values to the dictionary rather than try to leverage the single unimplemented last_flap attribute.

The new attributes could be parsed via a textfsm template with something like this. ^\s+Last\s+input\s+${LAST_INPUT},\s+output\s+${LAST_OUTPUT},\s+output\s+hang\s+${LAST_OUTPUT_HANG}\s*$$

the new proposed attributes could be:

  • last_input
  • last_output
  • last_output_hang

These are valid for Cisco based devices, but i am not sure about non Cisco devices. If they are available, I would recommend this change across all drivers for consistency.

Did you follow the steps from https://github.com/napalm-automation/napalm#faq

(Place an x between the square brackets where applicable)

  • Yes
  • No

Setup

win10 python 3.7.2

napalm version

(Paste verbatim output from pip freeze | grep napalm between quotes below)

napalm==2.4.0

Network operating system version

(Paste verbatim output from show version - or equivalent - between quotes below)

n/a

Steps to Reproduce the Issue

always reproducible since the library has not implemented this feature yet.

Error Traceback

(Paste the complete traceback of the exception between quotes below)

n/a

Contributor guide

Tech stack
python
Domain
backendinfrastructure
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
PythonNAPALM driver structureTextFSM templatesNetwork interface concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue proposes adding last input, last output, last output hang attributes to the get interfaces() method. Start by examining the current implementation in napalm/ios/ios.py and the corresponding TextFSM templates in napalm/ios/utils/textfsm templates/. Analyze how the 'show interface' output is parsed. Then replicate the pattern across other drivers (e.g., eos, junos) if the data is available. Check the existing 2 comments for any additional context or guidance. Ensure to update the documentation and include unit tests for the new attributes.