nannou-org/nannou

Fix orientation of teapot in `wgpu_instancing.rs` after update to 0.5

Open

#596 opened on May 10, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Rust (254 forks)batch import
buggood first issue

Repository metrics

Stars
 (4,662 stars)
PR merge metrics
 (Avg merge 24d 15h) (26 merged PRs in 30d)

Description

I just realised that I forgot to correct the orientation of the teapot in this example to account for wgpu's switch to having the y axis increase upwards (rather than downwards). Previously the teapot examples all used a view matrix with an inverted axis in order to account for the downwards y axis, as the original teapot vertices were intended for an upward y axis. This has been correct in the wgpu_teapot* examples in #594, but I forgot to correct it in wgpu_instancing.rs. This is a reminder to myself (or anyone) to fix it.

Contributor guide

Research direction
Update the view matrix or transformation in wgpu instancing.rs to account for the upward y axis in wgpu 0.5.
Tech stack
rust
Domain
computer graphics
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80