mysticatea/eslint-plugin-node

Missing from documentation: .gitignore check

Open

#117 opened on Apr 30, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (186 forks)github user discovery
accepteddocumentshelp wanted

Repository metrics

Stars
 (956 stars)
PR merge metrics
 (PR metrics pending)

Description

The documentation only mentions .npmignore, but the rule also checks .gitignore:

https://github.com/mysticatea/eslint-plugin-node/blob/2e2d464d9afe0ce1e1e2ad8899c6f744d182b4bb/lib/util/get-npmignore.js#L124

Contributor guide

Research direction
Update the documentation to mention that the rule also checks `.gitignore` in addition to `.npmignore`.
Tech stack
javascript
Domain
documentation
Issue type
Documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90