mysqljs/mysql

Auto-rollback of released connections without transaction commit

Open

#1,116 opened on Jun 3, 2015

View on GitHub
 (8 comments) (0 reactions) (0 assignees)JavaScript (2,502 forks)batch import
featurehelp wanted

Repository metrics

Stars
 (18,137 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When using a connection pool, releasing a connection should have a similar effect to ending a connection (aside from simply keeping the connection open). For starters, it would be extremely convenient to know if a connection has started a transaction (i.e. a boolean flag for isInTransaction) which would provide the following benefits:

  1. Passing an existing connection to child functions allows the child functions to operate independently and decide when/whether transactions need to be started (ability to shorten transaction lifecycles to reduce potential deadlocks) vs. managing this in parent code.
  2. If connections are released without making a call to "Connection.commit", they should really auto-rollback the transaction (just like a call to connection.end would do). This ensures that when the connection is re-used, the true effect is that the connection operates like a new connection (rather than having strange side-effects where existing transactions might cause deadlock).

Contributor guide

Research direction
Investigate the current behavior of releasing connections from the pool. Determine if there is an uncommitted transaction and implement auto rollback before returning the connection to the pool.
Tech stack
javascript
Domain
backenddatabase
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitJavaScriptMySQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60