mysqljs/mysql

0000-00-00 00:00:00 timestamp is returned as a string

Open

#1,040 opened on Mar 27, 2015

View on GitHub
 (8 comments) (0 reactions) (1 assignee)JavaScript (2,502 forks)batch import
help wantedquestion

Repository metrics

Stars
 (18,137 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

this should be equal to new Date(0) I believe. Here is what i 've done to make sure I always get a date:

if (typeof result.my_col ==="string"){
              result.my_col=new Date(0);
}
/*instanceof Date can also be used
or to cover only that case something like this:
result.my_col ==="0000-00-00 00:00:00"
but I don't remember if the above was the exact string given
*/

The rest of the timestamps is returned as dates so I wouldn't expect this behavior

Contributor guide

Research direction
Investigate the MySQL protocol or client code to see how timestamps are parsed, and handle the special case of '0000-00-00 00:00:00' to return a Date object (e.g., new Date(0)) instead of a string.
Tech stack
javascriptnodejs
Domain
backenddatabaseapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsMySQLGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65