mxstbr/pgp.asc

Check if key is valid and throw visible error

Open

#20 opened on Jul 27, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)HTML (5 forks)github user discovery
Backendbughelp wanted

Repository metrics

Stars
 (56 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently, in person.rb, if there is a file at domain.tld/pgp.asc which is not a valid PGP key, it still gets imported by GPGME, but the mail fails to send and Heroku throws an error. This could be handled better with a visible error on the webpage, I haven't found a way to check for the validity of a PGP key yet though.

Contributor guide

Research direction
Explore GPGME documentation to find methods to validate PGP key import and return a meaningful error message to the user.
Tech stack
ruby
Domain
backendsecurity
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Ruby
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75