musescore/MuseScore

MSCZ files corrupted beyond repair, because of corrupted ZIP file

Open

#16,339 opened on Feb 12, 2023

View on GitHub
 (14 comments) (0 reactions) (0 assignees)C++ (11,122 stars) (2,432 forks)batch import
P1corruptionhelp wanted

Description

Describe the bug A few times per month, someone somewhere in the world reports a file corruption where the ZIP container file has become corrupted, so that nothing of the contained score can be saved.

This has been the case for years now, and it is exactly the same in MS3 and MS4 for years now.

The problem exists in several variants:

  1. the saved MSCZ file is completely empty, i.e. 0KB
  2. the saved MSCZ file contains only zeros, no real data
  3. the saved MSCZ file contains seemingly random data
  4. the saved MSCZ file still looks a bit like a ZIP file but is still corrupted so that one or more files from it can't be read

In this issue, we will collect cases of this. When adding a case, please make sure to add the following information:

  • OS (Windows, macOS, Linux) and OS version
  • MuseScore version in which the file was saved the last time
  • Filename under which the file was saved
  • A link where the file in question can be downloaded, or at least a clear description which of the variants mentioned above is applicable

Please keep comments clear and concise, and don't use this thread for long back-and-forth conversations, to avoid making it longer than necessary.

Contributor guide

Tech stack
cpp
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
5
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C++ZIP file format
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
5
Research direction
Investigate the MSCZ file writing process to identify how ZIP files become corrupted. Review recent changes to file saving code for potential race conditions or file system errors. Examine user submitted corrupted files to determine common patterns and root causes.
MSCZ files corrupted beyond repair, because of corrupted ZIP file · musescore/MuseScore#16339 | Good First Issue