mumble-voip/mumble

Add "View Comment" context action to channels

Open

#6525 opened on Aug 4, 2024

View on GitHub
 (12 comments) (0 reactions) (0 assignees)C++ (5,642 stars) (1,062 forks)batch import
accessibilityclientfeature-requestgood first issueui

Description

Context

Currently, the only way to view channel comments is to hover the cursor over the channel, or click the comment indicator. Either way, the channel comment is only viewable as a pop-up, not a proper window which allows scrolling/copy-pasting.

Currently, there is no way to copy text from a channel comment or scroll through a channel comment that is too big to fit on screen at once without having "write ACL" permission on the channel and using the comment editor.

Description

There is currently a "View Comment" context action on users which lets you view their comment in a window which allows text selection and scrolling. This "View Comment" action should also be available on channels.

Mumble component

Client

OS-specific?

No

Additional information

No response

Contributor guide

Tech stack
cpp
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic C++Qt frameworkMumble client code structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the existing 'View Comment' implementation for users (likely in ContextMenu or related classes). Look for how user comments are displayed in a separate window. Then, adapt that logic to work on channels by finding where channel context menus are defined and adding a similar action. Review the Channel and Comment data structures to understand the comment retrieval mechanism. Check for any related pull requests or comments in the issue for additional hints.